Demonstrate containerized builds #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apljungquist
force-pushed
the
demo_containerized_builds
branch
from
fad0b3b to
28b2dab
Compare
This should make it easier to build the example apps in CI systems where setting up docker-in-docker is difficult. As desirable side effect of this is that it becomes easier to build the example apps on any system, including those where following the advanced setup may be difficult. To be able to build both inside and outside docker containers branching is introduced in the makefile. The added complexity is unfortunate but worthwhile in order to better support containerized builds. The goal is to eventually replace most of the makefile with a cargo plugin.
apljungquist
force-pushed
the
demo_containerized_builds
branch
from
28b2dab to
aee91d9
Compare
guoxe
approved these changes
May 28, 2024
apljungquist
added a commit
that referenced
this pull request
Jun 11, 2024
* upstream/main: chore: Group and sort imports (#23) Demonstrate containerized builds (#17) Factor out `app_logging` modules to lib crate (#24) chore(deps): bump the default group with 2 updates (#21) chore(deps): bump thiserror from 1.0.59 to 1.0.60 in the default group (#20) chore(deps): bump the default group with 3 updates (#13)
apljungquist
added a commit
that referenced
this pull request
Jun 25, 2024
* upstream/main: chore(deps): bump glib-sys from 0.19.5 to 0.19.8 in the default group (#28) chore: Explain more make targets (#27) Add embedded web page example (#14) chore: Group and sort imports (#23) Demonstrate containerized builds (#17) Factor out `app_logging` modules to lib crate (#24) chore(deps): bump the default group with 2 updates (#21) chore(deps): bump thiserror from 1.0.59 to 1.0.60 in the default group (#20) chore(deps): bump the default group with 3 updates (#13)
apljungquist
added a commit
that referenced
this pull request
Jul 5, 2024
…_wrapper_and_exampl * upstream/main: Rename environment variables controlling the Makefile (#26) Adopt dev container as primary environment (#39) Make the `build` verb build for only one target (#31) chore(deps): bump ghcr.io/devcontainers/features/common-utils (#38) chore(deps): bump log from 0.4.21 to 0.4.22 in the default group (#37) Add dev container (#36) Add link to acap-rs-app-template in `README.md` (#34) Document `python3-venv` dependency (#35) fix: Repair `Makefile` (#32) fix(embedded_web_page): Put web page in `html/` (#30) Organize dependencies consistently (#29) chore(deps): bump glib-sys from 0.19.5 to 0.19.8 in the default group (#28) chore: Explain more make targets (#27) Add embedded web page example (#14) chore: Group and sort imports (#23) Demonstrate containerized builds (#17) Factor out `app_logging` modules to lib crate (#24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to build the example apps in CI systems
where setting up docker-in-docker is difficult. As desirable side
effect of this is that it becomes easier to build the example apps on
any system, including those where following the advanced setup may be
difficult.
To be able to build both inside and outside docker containers branching
is introduced in the makefile. The added complexity is unfortunate but
worthwhile in order to better support containerized builds. The goal is
to eventually replace most of the
Makefilewith a cargo plugin.